i18n: add Korean translations #6963
Conversation
|
Apologies, not sure how I missed those two. Fixed them now though. |
|
(Your commit message is wrong by the way—it's I one eight N not I L eight N.) |
|
Banning myself from committing things when sleep deprived from now on... |
|
We now have the automation in place to request review properly and I'd like to move forward with merging these. Thank you and sorry for the wait. @RubenRME do you volunteer to be on the localization team for this language to be pinged on string changes? Would love if there was one other we could find too. |
|
@mitchellh wouldn't mind for sure! But definitely need someone to double check my Korean. |
|
Native Korean speaker here, there's some parts I'd love to make comments on but not sure how to suggest improvements. Should I open a PR against your fork? @RubenRME |
|
You could just add review comments… |
There was a problem hiding this comment.
Native Korean, Bi-lingual International student. Love Ghostty, very eager and happy to help in any way to help reach the Korean audience.
@mitchellh if there's still a spot to be pinged for string changes I would love to help out.
Took a look at existing translations, changed to more commonly used wording. If a Korean developer could take a look at it, that would be amazing.
Co-authored-by: Hojin You <[email protected]>
|
Hi @RMEngelbrecht, could you rebase this PR on main? |
|
Line no 148's word "inspector" translated into "검사 도구". but, line no 198's word "inspector" translated into "인스펙터". |
uhojin
left a comment
uhojin
left a comment
There was a problem hiding this comment.
Updated "Inspector" to use same translation
Co-authored-by: Hojin You <[email protected]>
|
Hi @morrighan, do you also volunteer to be on the localization team for this locale to be pinged on string changes? |
00-kat
left a comment
00-kat
left a comment
There was a problem hiding this comment.
Would you also mind adding a line like /po/ko_KR.UTF-8.po @ghostty-org/ko_KR to the CODEOWNERS file?
uhojin
left a comment
uhojin
left a comment
There was a problem hiding this comment.
Omitted "는", made it slightly more polite
Co-authored-by: Hojin You <[email protected]>
8 participants
This pull request adds Korean translations.
I do want to add that while I do speak Korean I am not a native speaker. I've done my best to provide translations as natural as possible, but I'd love it if a native speaker could improve it before merging.